Skip to content

sys: clock: add sys_clock api and remove posix from iso c time #90096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented May 18, 2025

This change removes the dependency that exists between POSIX and some libc's by creating a mutual dependency of both POSIX and the common C library.

  • sys_clock_gettime()
  • sys_clock_settime()
  • sys_clock_nanosleep()

For a number of samples and tests, we remove the explicit dependency on POSIX_TIMERS and XSI_SINGLE_PROCESS where it really should not be required.

Please see individual commits for details

  • sys: clock: additional sys_clock api calls
  • doc: release: 4.2.0: add sys_clock gettime settime nanosleep notes
  • libc: common: time: use sys_clock api rather than posix
  • libc: use the common libc time() implementation for most libcs
  • libc: common: thrd: use sys_clock_nanosleep() instead of nanosleep()
  • tests: libc: thrd: compare with thrd_success rather than ok or zero
  • tests: libc: thrd: do not pass NULL for thrd_sleep() duration
  • tests: libc: thrd: use timespec_from_timeout()
  • tests: lib: move time testsuite to c_lib
  • posix: use lib/os sys_clock implementation
  • net: remove dependency on posix for iso c time() function
  • samples: net: remove POSIX_TIMERS and XSI_SINGLE_PROCESS

Should be merged after #90060

@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch 2 times, most recently from a403e85 to 83dc940 Compare May 18, 2025 02:00
@cfriedt cfriedt changed the title timeutil: correct position of doxygen end-group comment kernel: add k_clock api May 18, 2025
@cfriedt cfriedt changed the title kernel: add k_clock api kernel: add k_clock api: remove posix dependency from iso c time May 18, 2025
@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch 13 times, most recently from db7b057 to fe430cf Compare May 18, 2025 17:57
@cfriedt
Copy link
Member Author

cfriedt commented May 18, 2025

  • adding tests for timespec_to_timeout() and timeout_from_timespec()

I'd like to get those in better shape before marking this ready for review.

@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch from fe430cf to 9a4203b Compare May 20, 2025 18:02
@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch 2 times, most recently from 5078a47 to 730558c Compare May 20, 2025 20:41
@peter-mitsis
Copy link
Collaborator

Question ... would the proposed k_clock APIs be better served somewhere under /subsys as something like sys_clock APIs? I am wary of them being placed under /kernel.

@cfriedt
Copy link
Member Author

cfriedt commented May 21, 2025

Question ... would the proposed k_clock APIs be better served somewhere under /subsys as something like sys_clock APIs? I am wary of them being placed under /kernel.

sys_clock could maybe work for CLOCK_MONOTONIC and CLOCK_REALTIME, although I think there is a chance that it could start to creep into the kernel as well, if things like per-cpu clocks or CLOCK_THREAD_CPUTIME_ID or CLOCK_PROCESS_CPUTIME_ID become a thing, which is probable.

It might be possible to reuse existing APIs for calculating some of those things though.

@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch 2 times, most recently from 793d367 to 19947db Compare May 21, 2025 22:24
@cfriedt cfriedt changed the title kernel: add k_clock api: remove posix dependency from iso c time sys: clock: add sys_clock api and remove posix from iso c time May 22, 2025
@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch 3 times, most recently from 370277c to c5bbd4f Compare May 22, 2025 04:19
Presumably the time testsuite was separate from the c library set of
testsuites because it had a depedency on POSIX.

Since that dependency no longer exists, colocate the time testsuite
with the other c library testsuites.

Signed-off-by: Chris Friedt <[email protected]>
cfriedt added 3 commits May 23, 2025 20:50
Use the newly added sys_clock API in lib/os for

* clock_gettime()
* clock_settime()
* clock_nanosleep() and nanosleep()
* gettimeofday()

Signed-off-by: Chris Friedt <[email protected]>
The ISO C function time() should not depend on POSIX and this was
corrected recently via the common libc time() implementation.

Remove this dependency from the network subsystem where it has
been unduly needed for some time.

Similarly, XSI_SINGLE_PROCESS was a dependency for time() via
picolibc, because the time() implementation in picolibc relies
on the POSIX gettimeofday() call.

However, since Zephyr's common libc time() implementation no longer
depends on that, it can be removed as a dependency in the network
subsystem as well.

Signed-off-by: Chris Friedt <[email protected]>
Remove POSIX_TIMERS and XSI_SINGLE_PROCESS dependencies from the aws
cloud sample and the lwm2m client sample, as they are no longer
required.

Signed-off-by: Chris Friedt <[email protected]>
@cfriedt cfriedt force-pushed the remove-posix-from-time-equation branch from deea029 to a4f6b31 Compare May 24, 2025 00:50
Copy link

Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Base OS Base OS Library (lib/os) area: C Library C Standard Library area: LWM2M area: Networking area: POSIX POSIX API Library area: Process area: Samples Samples area: Tests Issues related to a particular existing or missing test area: Utilities Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants