-
Notifications
You must be signed in to change notification settings - Fork 7.4k
sys: clock: add sys_clock api and remove posix from iso c time #90096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sys: clock: add sys_clock api and remove posix from iso c time #90096
Conversation
a403e85
to
83dc940
Compare
db7b057
to
fe430cf
Compare
I'd like to get those in better shape before marking this ready for review. |
fe430cf
to
9a4203b
Compare
5078a47
to
730558c
Compare
Question ... would the proposed k_clock APIs be better served somewhere under /subsys as something like sys_clock APIs? I am wary of them being placed under /kernel. |
It might be possible to reuse existing APIs for calculating some of those things though. |
793d367
to
19947db
Compare
370277c
to
c5bbd4f
Compare
Presumably the time testsuite was separate from the c library set of testsuites because it had a depedency on POSIX. Since that dependency no longer exists, colocate the time testsuite with the other c library testsuites. Signed-off-by: Chris Friedt <[email protected]>
d8a0351
to
deea029
Compare
Use the newly added sys_clock API in lib/os for * clock_gettime() * clock_settime() * clock_nanosleep() and nanosleep() * gettimeofday() Signed-off-by: Chris Friedt <[email protected]>
The ISO C function time() should not depend on POSIX and this was corrected recently via the common libc time() implementation. Remove this dependency from the network subsystem where it has been unduly needed for some time. Similarly, XSI_SINGLE_PROCESS was a dependency for time() via picolibc, because the time() implementation in picolibc relies on the POSIX gettimeofday() call. However, since Zephyr's common libc time() implementation no longer depends on that, it can be removed as a dependency in the network subsystem as well. Signed-off-by: Chris Friedt <[email protected]>
Remove POSIX_TIMERS and XSI_SINGLE_PROCESS dependencies from the aws cloud sample and the lwm2m client sample, as they are no longer required. Signed-off-by: Chris Friedt <[email protected]>
deea029
to
a4f6b31
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat 👌
This change removes the dependency that exists between POSIX and some libc's by creating a mutual dependency of both POSIX and the common C library.
For a number of samples and tests, we remove the explicit dependency on POSIX_TIMERS and XSI_SINGLE_PROCESS where it really should not be required.
Please see individual commits for details
Should be merged after #90060